-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StructureChange-chapter1 #32
base: restructure-book
Are you sure you want to change the base?
Conversation
Hi, Robert, the changes made are as follows:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think it's fine for now, just a couple requests:
- add any notes to quizzes
- can you check my notes about what you did in files
./docs/restructure.md
? Add anything you think is missing
Once this is done, we can merge the PR. Note that I made a new branch calledrestructure-book
to collect all of the changes. This way you can start working with smaller PR's to keep track of things more easily (e.g., can start a new one for chapter 2, or chapter 1 nutshell).
@rlanzafame Hi Robert, I changed the nutshell in the commits. Are there something more to change for Chapter 1? |
Hi @tshiya731 it looks good! I just have a question about the section titles that show up in the right-hand table of contents for a specific page. There is not a 1-to-1 correspondence between the "theory" and "nutshell" versions. Do you think this is an advantage or disadvantage from a student perspective? I kind of like it as-is because it gives a different perspective on the same topics. Take this page for example: If you like it this way we can merge it. I will think about a nice way to provide links/buttons to jump between the theory and nutshell pages. |
Hi @rlanzafame, sorry it took so long to reply as I just saw the message. |
Hi Robert, in this PR i made some changes about the structure of Chapter1:
@rlanzafame