Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring #4

Open
TaniaMalhotra opened this issue Oct 13, 2020 · 7 comments · Fixed by #17
Open

Code refactoring #4

TaniaMalhotra opened this issue Oct 13, 2020 · 7 comments · Fixed by #17

Comments

@TaniaMalhotra
Copy link
Owner

Refactor to remove unnecessary tabs and spaces

@janethavi
Copy link

Can I get assigned for this issue?

@TaniaMalhotra
Copy link
Owner Author

Hii @janethavi
Thank you for your contribution!
But this issue is meant for first timers and I can see a good amount of contributions on your profile.
Feel free to take up/open another issue 😊

@sculley
Copy link
Contributor

sculley commented Oct 13, 2020

Hi @TaniaMalhotra

Can I be assigned this issue please?

@sculley
Copy link
Contributor

sculley commented Oct 16, 2020

Hi, can you clarify

Refactor to remove unnecessary tabs and spaces

Do you mean tabs and spaces in the Tweet message?

@TaniaMalhotra
Copy link
Owner Author

I meant the extra newlines in the code

I tend to follow the convention of 2 blank lines after every function and 2 blank lines after import statements. You may remove the extras

@sculley
Copy link
Contributor

sculley commented Oct 18, 2020

PEP8 the styling guide for Python recommends 2 blank lines after the import block and 2 blank lines after every function.

I can see the following pep8 validation warning/errors using flake8

bot.py:4:1: F401 'json' imported but unused
bot.py:12:1: E302 expected 2 blank lines, found 1
bot.py:13:80: E501 line too long (130 > 79 characters)
bot.py:16:1: E305 expected 2 blank lines after class or function definition, found 1
bot.py:18:1: E265 block comment should start with '# '
bot.py:19:17: E231 missing whitespace after ','
bot.py:22:1: E302 expected 2 blank lines, found 1
bot.py:26:1: E302 expected 2 blank lines, found 1
bot.py:31:21: E231 missing whitespace after ','
bot.py:33:25: E231 missing whitespace after ','
bot.py:36:17: E265 block comment should start with '# '
bot.py:36:80: E501 line too long (96 > 79 characters)
bot.py:40:41: E251 unexpected spaces around keyword / parameter equals
bot.py:40:43: E251 unexpected spaces around keyword / parameter equals
bot.py:53:21: E231 missing whitespace after ','
bot.py:62:1: E303 too many blank lines (3)
bot.py:69:1: E305 expected 2 blank lines after class or function definition, found 1

I will submit a PR to resolve these.

@sculley
Copy link
Contributor

sculley commented Oct 18, 2020

Hello, please see [PR #17]

@TaniaMalhotra TaniaMalhotra linked a pull request Oct 18, 2020 that will close this issue
@sculley sculley removed their assignment Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants