sort player aliases by last seen at

TaloDev · Nov 2, 2024 · 4e27588 · 4e27588
1 parent 3d98d60
commit 4e27588
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/src/__mocks__/playerAliasMock.ts b/src/__mocks__/playerAliasMock.ts
@@ -7,6 +7,7 @@ export default function playerAliasMock(extra: Partial<PlayerAlias> = {}): Playe
     service: PlayerAliasService.STEAM,
     identifier: 'yxre12',
     player: playerMock(),
+    lastSeenAt: new Date().toISOString(),
     createdAt: new Date().toISOString(),
     updatedAt: new Date().toISOString(),
     ...extra

diff --git a/src/components/PlayerAliases.tsx b/src/components/PlayerAliases.tsx
@@ -13,7 +13,7 @@ type PlayerAliasesProps = {
 export default function PlayerAliases({
   aliases
 }: PlayerAliasesProps) {
-  const sortedAliases = useSortedItems(aliases, 'createdAt')
+  const sortedAliases = useSortedItems(aliases, 'lastSeenAt')
 
   const getIcon = useCallback((alias: PlayerAlias) => {
     /* v8ignore next */

diff --git a/src/components/__tests__/PlayerAliases.test.tsx b/src/components/__tests__/PlayerAliases.test.tsx
@@ -16,9 +16,9 @@ describe('<PlayerAliases />', () => {
 
   it('should render the latest alias and an indicator for how many more', () => {
     const aliases: PlayerAlias[] = [
-      playerAliasMock({ service: PlayerAliasService.STEAM, identifier: 'yxre12', createdAt: '2024-10-28 10:00:00' }),
-      playerAliasMock({ service: PlayerAliasService.USERNAME, identifier: 'ryet12', createdAt: '2024-10-27 10:00:00' }),
-      playerAliasMock({ service: PlayerAliasService.EPIC, identifier: 'epic_23rd', createdAt: '2024-10-26 10:00:00' })
+      playerAliasMock({ service: PlayerAliasService.STEAM, identifier: 'yxre12', lastSeenAt: '2024-10-28 10:00:00' }),
+      playerAliasMock({ service: PlayerAliasService.USERNAME, identifier: 'ryet12', lastSeenAt: '2024-10-27 10:00:00' }),
+      playerAliasMock({ service: PlayerAliasService.EPIC, identifier: 'epic_23rd', lastSeenAt: '2024-10-26 10:00:00' })
     ]
 
     render(<PlayerAliases aliases={aliases} />)

diff --git a/src/entities/playerAlias.ts b/src/entities/playerAlias.ts
@@ -15,6 +15,7 @@ export const playerAliasSchema = z.object({
   service: z.string(),
   identifier: z.string(),
   player: z.lazy(() => basePlayerSchema),
+  lastSeenAt: z.string().datetime(),
   createdAt: z.string().datetime(),
   updatedAt: z.string().datetime()
 })

diff --git a/src/pages/PlayerProfile.tsx b/src/pages/PlayerProfile.tsx
@@ -54,7 +54,7 @@ export default function PlayerProfile() {
   const [player] = usePlayer()
   const navigate = useNavigate()
 
-  const sortedAliases = useSortedItems(player?.aliases ?? [], 'createdAt')
+  const sortedAliases = useSortedItems(player?.aliases ?? [], 'lastSeenAt')
 
   const activeGame = useRecoilValue(activeGameState) as SelectedActiveGame
   const user = useRecoilValue(userState) as AuthedUser
@@ -105,7 +105,7 @@ export default function PlayerProfile() {
 
       <SecondaryTitle>Aliases</SecondaryTitle>
 
-      <Table columns={['Alias', 'Created at', 'Updated at']}>
+      <Table columns={['Alias', 'Created at', 'Last seen']}>
         <TableBody
           iterator={sortedAliases}
           configureClassnames={(_, idx) => ({
@@ -117,7 +117,7 @@ export default function PlayerProfile() {
             <>
               <TableCell className='min-w-60'><PlayerAliases aliases={[alias]} /></TableCell>
               <DateCell>{format(new Date(alias.createdAt), 'dd MMM Y, HH:mm')}</DateCell>
-              <DateCell>{format(new Date(alias.updatedAt), 'dd MMM Y, HH:mm')}</DateCell>
+              <DateCell>{format(new Date(alias.lastSeenAt), 'dd MMM Y, HH:mm')}</DateCell>
             </>
           )}
         </TableBody>