Skip to content

Commit

Permalink
Gem's, ruby updates
Browse files Browse the repository at this point in the history
  • Loading branch information
nadavshatz committed Jun 30, 2020
1 parent b4fbd08 commit 5fe6dbc
Show file tree
Hide file tree
Showing 8 changed files with 46 additions and 55 deletions.
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.5.1
2.7.1
65 changes: 28 additions & 37 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,62 +1,53 @@
PATH
remote: .
specs:
noun-project-api (2.0.0)
noun-project-api (3.0.0)
oauth (~> 0.5)

GEM
remote: https://rubygems.org/
specs:
coderay (1.1.2)
concurrent-ruby (1.0.5)
concurrent-ruby (1.0.5-java)
diff-lcs (1.3)
faker (1.9.1)
i18n (>= 0.7)
ffi (1.9.25-java)
i18n (1.1.0)
coderay (1.1.3)
concurrent-ruby (1.1.6)
diff-lcs (1.4.2)
faker (2.13.0)
i18n (>= 1.6, < 2)
i18n (1.8.3)
concurrent-ruby (~> 1.0)
method_source (0.9.0)
method_source (1.0.0)
oauth (0.5.4)
pry (0.11.3)
coderay (~> 1.1.0)
method_source (~> 0.9.0)
pry (0.11.3-java)
coderay (~> 1.1.0)
method_source (~> 0.9.0)
spoon (~> 0.0)
rake (12.3.1)
rspec (3.8.0)
rspec-core (~> 3.8.0)
rspec-expectations (~> 3.8.0)
rspec-mocks (~> 3.8.0)
rspec-core (3.8.0)
rspec-support (~> 3.8.0)
rspec-expectations (3.8.1)
pry (0.13.1)
coderay (~> 1.1)
method_source (~> 1.0)
rake (13.0.1)
rspec (3.9.0)
rspec-core (~> 3.9.0)
rspec-expectations (~> 3.9.0)
rspec-mocks (~> 3.9.0)
rspec-core (3.9.2)
rspec-support (~> 3.9.3)
rspec-expectations (3.9.2)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.8.0)
rspec-mocks (3.8.0)
rspec-support (~> 3.9.0)
rspec-mocks (3.9.1)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.8.0)
rspec-support (3.8.0)
rspec-support (~> 3.9.0)
rspec-support (3.9.3)
rspec_junit_formatter (0.4.1)
rspec-core (>= 2, < 4, != 2.12.0)
semver (1.0.1)
spoon (0.0.6)
ffi

PLATFORMS
java
ruby

DEPENDENCIES
faker (~> 1.9)
faker (~> 2.13)
noun-project-api!
pry (~> 0.11)
rake (~> 12.3)
rspec (~> 3.8)
pry (~> 0.13)
rake (~> 13.0)
rspec (~> 3.9)
rspec_junit_formatter (~> 0.4)
semver (~> 1.0)

BUNDLED WITH
1.16.4
2.1.4
8 changes: 4 additions & 4 deletions noun-project-api.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ Gem::Specification.new do |s|

s.add_runtime_dependency 'oauth', '~> 0.5'

s.add_development_dependency 'rake', '~> 12.3'
s.add_development_dependency 'rspec', '~> 3.8'
s.add_development_dependency 'faker', '~> 1.9'
s.add_development_dependency 'rake', '~> 13.0'
s.add_development_dependency 'rspec', '~> 3.9'
s.add_development_dependency 'faker', '~> 2.13'
s.add_development_dependency 'semver', '~> 1.0'
s.add_development_dependency 'rspec_junit_formatter', '~> 0.4'
s.add_development_dependency 'pry', '~> 0.11'
s.add_development_dependency 'pry', '~> 0.13'
end
2 changes: 1 addition & 1 deletion spec/lib/noun-project-api/collection_retriever_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

RSpec.describe NounProjectApi::CollectionRetriever do
before :each do
@collection = NounProjectApi::CollectionRetriever.new(Faker::Internet.password(16), Faker::Internet.password(16))
@collection = NounProjectApi::CollectionRetriever.new(Faker::Internet.password(min_length: 16), Faker::Internet.password(min_length: 16))
@valid_hash = JSON.parse(Fakes::Results::COLLECTION_VALID)
@valid_response = OpenStruct.new(
body: Fakes::Results::COLLECTION_VALID,
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/noun-project-api/icon_retriever_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

RSpec.describe NounProjectApi::IconRetriever do
before :each do
@icon = NounProjectApi::IconRetriever.new(Faker::Internet.password(16), Faker::Internet.password(16))
@icon = NounProjectApi::IconRetriever.new(Faker::Internet.password(min_length: 16), Faker::Internet.password(min_length: 16))
@valid_hash = JSON.parse(Fakes::Results::ICON_VALID)
@valid_response = OpenStruct.new(
body: Fakes::Results::ICON_VALID,
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/noun-project-api/icons_retriever_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

RSpec.describe NounProjectApi::IconsRetriever do
before :each do
@icons = NounProjectApi::IconsRetriever.new(Faker::Internet.password(16), Faker::Internet.password(16))
@icons = NounProjectApi::IconsRetriever.new(Faker::Internet.password(min_length: 16), Faker::Internet.password(min_length: 16))
end

context "recent uploads" do
Expand Down
12 changes: 6 additions & 6 deletions spec/lib/noun-project-api/reporter_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@

RSpec.describe NounProjectApi::Reporter do
it "raises an error when initialized without token" do
expect { NounProjectApi::Reporter.new(nil, Faker::Internet.password(16)) }.to raise_error(ArgumentError)
expect { NounProjectApi::Reporter.new(nil, Faker::Internet.password(min_length: 16)) }.to raise_error(ArgumentError)
end

it "raises an error when initialized without secret" do
expect { NounProjectApi::Reporter.new(Faker::Internet.password(16), nil) }.to raise_error(ArgumentError)
expect { NounProjectApi::Reporter.new(Faker::Internet.password(min_length: 16), nil) }.to raise_error(ArgumentError)
end

it "initializes the values properly" do
token = Faker::Internet.password(16)
secret = Faker::Internet.password(16)
token = Faker::Internet.password(min_length: 16)
secret = Faker::Internet.password(min_length: 16)
reporter = NounProjectApi::Reporter.new(token, secret)

expect(reporter.token).to eq(token)
Expand All @@ -20,8 +20,8 @@

context "reports ids usage" do
before :each do
token = Faker::Internet.password(16)
secret = Faker::Internet.password(16)
token = Faker::Internet.password(min_length: 16)
secret = Faker::Internet.password(min_length: 16)
@reporter = NounProjectApi::Reporter.new(token, secret)
end

Expand Down
8 changes: 4 additions & 4 deletions spec/lib/noun-project-api/retriever_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@

RSpec.describe NounProjectApi::Retriever do
it "raises an error when initialized without token" do
expect { NounProjectApi::Retriever.new(nil, Faker::Internet.password(16)) }.to raise_error(ArgumentError)
expect { NounProjectApi::Retriever.new(nil, Faker::Internet.password(min_length: 16)) }.to raise_error(ArgumentError)
end

it "raises an error when initialized without secret" do
expect { NounProjectApi::Retriever.new(Faker::Internet.password(16), nil) }.to raise_error(ArgumentError)
expect { NounProjectApi::Retriever.new(Faker::Internet.password(min_length: 16), nil) }.to raise_error(ArgumentError)
end

it "initializes the values properly" do
token = Faker::Internet.password(16)
secret = Faker::Internet.password(16)
token = Faker::Internet.password(min_length: 16)
secret = Faker::Internet.password(min_length: 16)
retriever = NounProjectApi::Retriever.new(token, secret)

expect(retriever.token).to eq(token)
Expand Down

0 comments on commit 5fe6dbc

Please sign in to comment.