Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Allow stdWrap on MM SOLR_RELATION cObject #3409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

b3nkai
Copy link
Contributor

@b3nkai b3nkai commented Nov 16, 2022

What this pr does

Allow stdWrap on MM SOLR_RELATION cObject

How to test

Add a stdWrap on a MM relation (like sys_category):

plugin.tx_solr.index.queue { 
  pages { 
    myfield_stringM = SOLR_RELATION 
    myfield_stringM { 
      localField = myfield 
      stdWrap.dataWrap = before | after 
    }
  } 
}

Fixes: #3408

@b3nkai b3nkai force-pushed the solr-relation-stdwrap branch from 74b061f to 4661617 Compare November 16, 2022 15:24
@dkd-kaehm
Copy link
Collaborator

@b3nkai
Thanks for fixing that issue.
We want integration test case[s] for that.
Would you like to try setup the fixture and integration test?

Rlated Issues: #3152, #2147, #2743

@dkd-kaehm dkd-kaehm force-pushed the solr-relation-stdwrap branch 2 times, most recently from df342ae to 45cd2de Compare December 22, 2022 21:49
@b3nkai
Copy link
Contributor Author

b3nkai commented Jan 11, 2023

Hi !
This is a good idea but to be honest I'm not sure to find some time in the next weeks.
I keep that in my todo list but if someone could take care of it it would go faster :)

@dkd-kaehm dkd-kaehm force-pushed the solr-relation-stdwrap branch from 45cd2de to 66b8f90 Compare January 25, 2023 09:48
@dkd-kaehm dkd-kaehm force-pushed the solr-relation-stdwrap branch from 66b8f90 to a7e43e6 Compare January 25, 2023 09:50
Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change brakes currently the simple relations:
See the build logs(available up to 2023.02.05):
https://github.com/TYPO3-Solr/ext-solr/actions/runs/4004683414/jobs/6874144860#step:12:112

1) ApacheSolrForTypo3\Solr\Tests\Integration\ContentObject\RelationTest::canFallbackToPagesTableIfPagesLanguageOverlayTCAHasNoDefinitionForLocalColumn with data set #0 ('solr_relation_can_fallback_to...ld.xml')
Can not fallback to table "pages" on non existent column configuration in TCA for table "pages_language_overlay".
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'Some Category'
+''

/home/runner/work/ext-solr/ext-solr/Tests/Integration/ContentObject/RelationTest.php:50

2) ApacheSolrForTypo3\Solr\Tests\Integration\ContentObject\RelationTest::canFallbackToPagesTableIfPagesLanguageOverlayTCAHasNoDefinitionForLocalColumn with data set #1 ('solr_relation_can_get_related...ca.xml')
Can not fallback to table "pages" on non existent column configuration in TCA for table "pages_language_overlay".
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'Some Category'
+''

/home/runner/work/ext-solr/ext-solr/Tests/Integration/ContentObject/RelationTest.php:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Allow stdWrap on MM SOLR_RELATION cObject
2 participants