-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Allow stdWrap on MM SOLR_RELATION cObject #3409
base: main
Are you sure you want to change the base?
Conversation
74b061f
to
4661617
Compare
df342ae
to
45cd2de
Compare
Hi ! |
45cd2de
to
66b8f90
Compare
66b8f90
to
a7e43e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change brakes currently the simple relations:
See the build logs(available up to 2023.02.05):
https://github.com/TYPO3-Solr/ext-solr/actions/runs/4004683414/jobs/6874144860#step:12:112
1) ApacheSolrForTypo3\Solr\Tests\Integration\ContentObject\RelationTest::canFallbackToPagesTableIfPagesLanguageOverlayTCAHasNoDefinitionForLocalColumn with data set #0 ('solr_relation_can_fallback_to...ld.xml')
Can not fallback to table "pages" on non existent column configuration in TCA for table "pages_language_overlay".
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'Some Category'
+''
/home/runner/work/ext-solr/ext-solr/Tests/Integration/ContentObject/RelationTest.php:50
2) ApacheSolrForTypo3\Solr\Tests\Integration\ContentObject\RelationTest::canFallbackToPagesTableIfPagesLanguageOverlayTCAHasNoDefinitionForLocalColumn with data set #1 ('solr_relation_can_get_related...ca.xml')
Can not fallback to table "pages" on non existent column configuration in TCA for table "pages_language_overlay".
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'Some Category'
+''
/home/runner/work/ext-solr/ext-solr/Tests/Integration/ContentObject/RelationTest.php:50
363e234
to
a9bae2f
Compare
e865edc
to
89d9f0d
Compare
16bf8c5
to
dfcdd98
Compare
What this pr does
Allow stdWrap on MM SOLR_RELATION cObject
How to test
Add a stdWrap on a MM relation (like sys_category):
Fixes: #3408