Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outSAMtype parameter #13

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Remove outSAMtype parameter #13

merged 1 commit into from
Jul 19, 2024

Conversation

LKress
Copy link
Contributor

@LKress LKress commented Jul 19, 2024

Sorting the output BAM by coordinate can lead to errors, when the input fastq files are derived from coordinate sorted bam files (alexdobin/STAR#289). Thus, suggesting to have the default unmapped and let the user decide.

@LKress LKress requested a review from priesgo July 19, 2024 09:58
Copy link
Collaborator

@priesgo priesgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Also different sort operations could be customised with the --additional_args

@priesgo priesgo merged commit ccbdb3e into master Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants