Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-exposed value for changing the GameBanana HttpClient's Timeout property #71

Open
GreemDev opened this issue Jan 3, 2025 · 2 comments · May be fixed by #77
Open

User-exposed value for changing the GameBanana HttpClient's Timeout property #71

GreemDev opened this issue Jan 3, 2025 · 2 comments · May be fixed by #77
Labels
enhancement New feature or request

Comments

@GreemDev
Copy link
Contributor

GreemDev commented Jan 3, 2025

No description provided.

@ArchLeaders ArchLeaders added the enhancement New feature or request label Jan 3, 2025
@SirMrMister
Copy link

SirMrMister commented Jan 3, 2025

Reason: I think that TKMM may be throwing out the timeout error and interrupting a download from the GB browser if said mod is big enough that GB's speed cap makes it take longer than the timeout (currently 2 minutes).

No such error from downloading any smaller mods.

https://discord.com/channels/1179611100183011429/1191595001088573450/1324499955674517577
image

If it can't be updated on the fly, at least set it to 10 minutes.

@ArchLeaders
Copy link
Member

That's not how timeout works. If the server responds with a single byte every 119 seconds, it will never time out. The issue is that it stalls for more than that causing the timeout.

Either way, an option will be added to change this.

@ArchLeaders ArchLeaders linked a pull request Jan 22, 2025 that will close this issue
@ArchLeaders ArchLeaders linked a pull request Jan 22, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants