Fix bug in the default creation of VisMeta #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage ? 89.13%
=======================================
Files ? 7
Lines ? 902
Branches ? 0
=======================================
Hits ? 804
Misses ? 98
Partials ? 0 ☔ View full report in Codecov by Sentry. |
samaloney
reviewed
May 28, 2024
changelog/66.bugfix.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Fix bug that happens when you create a Visibility object with default meta. | |||
There was a problem hiding this comment.
Suggested change
| Fix bug that happens when you create a Visibility object with default meta. | |
| Fix bug when you creating :class:`~xrayvision.visibility.Visibilities` with default meta. |
There was a problem hiding this comment.
Suggested change
| Fix bug that happens when you create a Visibility object with default meta. | |
| Fix bug when creating :class:`~xrayvision.visibility.Visibilities` with default meta. |
|
Once the changelog is fixed, I am happy to approve this PR. |
samaloney
approved these changes
May 28, 2024
DanRyanIrish
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug that happen once you create a Visibility object with default
meta.