From dcd2a3ea1d63e93a28748701d70e3dbb6aa7d366 Mon Sep 17 00:00:00 2001 From: Paolo Massa <64010598+paolomassa@users.noreply.github.com> Date: Tue, 28 May 2024 11:32:14 +0200 Subject: [PATCH] Fix bug in the default creation of VisMeta (#66) * Fixed bug in the default creation of VisMeta * Add changelog file * Fix changelog --- changelog/66.bugfix.rst | 1 + xrayvision/visibility.py | 6 +----- 2 files changed, 2 insertions(+), 5 deletions(-) create mode 100644 changelog/66.bugfix.rst diff --git a/changelog/66.bugfix.rst b/changelog/66.bugfix.rst new file mode 100644 index 0000000..ba50414 --- /dev/null +++ b/changelog/66.bugfix.rst @@ -0,0 +1 @@ +Fix bug when creating :class:`~xrayvision.visibility.Visibilities` with default meta. diff --git a/xrayvision/visibility.py b/xrayvision/visibility.py index 0740c07..f7e4dfe 100644 --- a/xrayvision/visibility.py +++ b/xrayvision/visibility.py @@ -285,10 +285,6 @@ def __init__( self._uv_key = "uv" self._units_key = "units" - # Build meta. Make sure that phase center is included. - if not isinstance(meta, VisMetaABC): - meta = VisMeta(meta) - # Construct underlying data object. dims = [f"dim{i}" for i in range(0, len(visibilities.shape))] dims[_uv_axis] = self._uv_key @@ -307,7 +303,7 @@ def __init__( if phase_uncertainty is not None: data[self._phase_uncert_key] = (dims, phase_uncertainty.to_value(phase.unit)) if meta is None: - meta = VisMeta(dict()) + meta = VisMeta() vis_labels = getattr(meta, "vis_labels", None) if vis_labels is not None: if len(vis_labels) != nvis: