Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user_template_dir to config #25

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

Dragon-Git
Copy link
Contributor

implement #24

@amykyta3
Copy link
Member

Beware that I plan to refactor the UVM exporter significantly. This includes significantly reducing the use of Jinja which means this change will be superseded relatively soon.

@amykyta3
Copy link
Member

Please be sure to test this change first. As it is implemented currently, it will result in a Python exception if loaded by the PeakRDL tool.

@Dragon-Git
Copy link
Contributor Author

Please be sure to test this change first. As it is implemented currently, it will result in a Python exception if loaded by the PeakRDL tool.

Sorry, I should have marked it as a draft before completing the pull request.

Beware that I plan to refactor the UVM exporter significantly. This includes significantly reducing the use of Jinja which means this change will be superseded relatively soon.

In our existing workflow, we rely on our proprietary templates and context. Consequently, prior to the 3.0 release, we seek a user-friendly method to seamlessly integrate our customized templates. Your comprehension is greatly appreciated.

@amykyta3
Copy link
Member

amykyta3 commented Sep 1, 2023

Thanks for fixing!
And yes, although in v3.0 I will be reducing the use of Jinja templates, I still plan to make it very extensible for the exact reason you mentioned (see #17)

@amykyta3 amykyta3 merged commit 3473964 into SystemRDL:main Sep 1, 2023
10 checks passed
@Dragon-Git Dragon-Git deleted the add-user_template_dir-to-config branch September 1, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants