Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAVEN 2.10.2 #573

Merged
merged 2 commits into from
Nov 23, 2024
Merged

RAVEN 2.10.2 #573

merged 2 commits into from
Nov 23, 2024

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Nov 23, 2024

Main improvements in this PR:

  • fix:
    • addMets if metNames and not mets identifiers are given
    • addRxns when adding empty subSystems if the model uses cell arrays of cells for subSystems
    • importModel properly parsing of annotations if identifiers.org/name:value is used instead of identifiers.org/name/value
  • features:
    • changeGrRules can change the same grRule for multiple reactions simultaneously
    • replaceMets can use metabolite identifiers instead of metabolite names
  • refactor:
    • use getGenesFromGrRules in checkModelStruct, changeGrRules and importModel, to correctly split and/or relationships
  • documentation:

Instructions on merging this PR:

  • This PR has develop as target branch, and will be resolved with a squash-merge.
  • This PR has main as target branch, and will be resolved with a merge commit.

…eplaceMets and changeGrRules options (#571)

* fix: addMets if metNames and not mets are given

* feat: changeGrRules multiple rxns same grRule

* fix: addRxns subSystems correct format

* fix: subSystems if cell array of cell arrays

* fix: importModel if identifiers.org/name:value

* refactor: checkModelStruct use getGenesFromGrRules

* feat: replaceMets can use identifiers instead

* refactor: use getGenesFromGrRules

* doc: checkRxn clarify meaning of output
Copy link

github-actions bot commented Nov 23, 2024

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 > Installation type                    Advanced (via git)
> Installing from location /home/m/actions-runner/_work/RAVEN/RAVEN
> Checking RAVEN release 2.10.1
> You are running the latest RAVEN release
> Checking MATLAB release 2020b
> Checking system architecture glnxa64
> Set RAVEN in MATLAB path Pass
> Save MATLAB path Pass
> Make binaries executable Pass

> Add Java paths for Excel format Pass
> Checking libSBML version 5.20.2
> Checking model import and export
> Import Excel format Pass
> Export Excel format Pass
> Import SBML format Pass
> Export SBML format Pass
> Import YAML format Pass
> Export YAML format Pass

> Checking for LP solvers
> glpk Pass
> gurobi Pass
> scip Fail
> cobra Pass
> Set RAVEN solver gurobi

> Checking BLAST+ Pass
> Checking DIAMOND Pass
> Checking HMMER Pass

> Checking function uniqueness Pass

*** checkInstallation complete ***

SCIP MEX binary not installed or not functional, some fillGapsLargeTests skipped.
SCIP MEX binary not installed or not functional, some fillGapsSmallTests skipped.
Running blastPlusTests
.
Done blastPlusTests

Running cdhitTests
.
Done cdhitTests

Running checkTasksTests
.
Done checkTasksTests

Running diamondTests
.
Done diamondTests

Running fillGapsLargeTests
.
Done fillGapsLargeTests

Running fillGapsSmallTests
.
Done fillGapsSmallTests

Running hmmerTests
.
Done hmmerTests

Running importExportTests
......
Done importExportTests

Running mafftTests
.
Done mafftTests

Running miriamTests
.
Done miriamTests

Running modelAbilitiesTests
........
Done modelAbilitiesTests

Running modelConversionTests
.
Done modelConversionTests

Running modelCurationTests
.......... ........
Done modelCurationTests

Running modelSortingTests
..
Done modelSortingTests

Running solverTests
..
Error occurred in solverTests/testSCIP and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using solverTests>testSCIP (line 77)
SCIP MEX binary not installed or not functional.
..
Done solverTests

Running tinitTests
..........
Done tinitTests

Failure Summary:

Name Failed Incomplete Reason(s)
=====================================================
solverTests/testSCIP X X Errored.

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk merged commit c5a805b into main Nov 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant