Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with nesting of share links #1615

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

cjmyers
Copy link
Collaborator

@cjmyers cjmyers commented Jan 30, 2025

Closes #1613

@cjmyers cjmyers requested a review from danielfang97 January 30, 2025 00:17
@cjmyers
Copy link
Collaborator Author

cjmyers commented Jan 30, 2025

Test test upload something, then create a share link. Log out and access via share link. Then try to follow items in table to see if the share links nest down

@danielfang97
Copy link
Collaborator

Tested. Almost all links are working except sequence links. Sequence links are not getting the hashcode

@cjmyers
Copy link
Collaborator Author

cjmyers commented Feb 7, 2025

I tested this again, and sequences worked for me. Can you double check? I opened a private collection with a part that has a sequence. I generated a share link for the collection. I then logged out, and used the share link to reaccess the collection. I then clicked on the part and then clicked on the sequence, and the sequence page opened for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share link issue
2 participants