Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent circular collections #1608

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Prevent circular collections #1608

merged 3 commits into from
Jan 29, 2025

Conversation

cjmyers
Copy link
Collaborator

@cjmyers cjmyers commented Dec 24, 2024

Closes #1390

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@cjmyers cjmyers requested a review from danielfang97 December 24, 2024 22:28
@cjmyers
Copy link
Collaborator Author

cjmyers commented Dec 24, 2024

Be sure to test both GUI and API

@cjmyers cjmyers closed this Dec 24, 2024
@cjmyers cjmyers reopened this Jan 14, 2025
Copy link
Collaborator

@danielfang97 danielfang97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctly doesn't show up on add to collection list.
For API, throws a 500 error when attempting to make a circular collection. If that's correct, then should be good to merge.

@cjmyers cjmyers merged commit 544350e into master Jan 29, 2025
4 checks passed
@cjmyers cjmyers deleted the preventCircColl branch January 29, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circuluar dependencies
2 participants