Issue 249 #260
Draft
Issue 249 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you; I will review and see if I can make use of the work that you have done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @jakebeal
I tried, but I don't think I made any meaningful progress. Leaving the code here in case it would help the next person.
I think the visit_interaction and visit_participant might be useful for the next person (see python scripts added, specifically compare_participation.py), but I struggled with higher order classes. The way the tests are structured requires adding everything to a document, so all the converters for higher-order classes have to be written in order to test the lower order classes. I see why this lack of modularity happens (Ids are assigned when adding to a top-level), but this makes it very hard to start with the easiest classes (not top-level).
Reading the spec I could not figure out how to map the multiple SBOL2 classes that map to SBOL3 component and subcomponent. Not having used SBOL in the past, I don't think I can contribute this feature.