Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blockchain to gas mapping #315

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add blockchain to gas mapping #315

wants to merge 12 commits into from

Conversation

GulfOfAlaska
Copy link
Collaborator

No description provided.

sarah-thong
sarah-thong reviewed Jan 14, 2025
View reviewed changes
configs/testnet.json Outdated Show resolved Hide resolved
configs/testnet.json Show resolved Hide resolved
configs/devnet.json Outdated Show resolved Hide resolved
configs/mainnet.json Show resolved Hide resolved
configs/mainnet.json Outdated Show resolved Hide resolved
configs/mainnet.json Outdated Show resolved Hide resolved
configs/mainnet.json Outdated Show resolved Hide resolved
configs/mainnet.json Outdated Show resolved Hide resolved
configs/mainnet.json Show resolved Hide resolved
configs/mainnet.json Outdated Show resolved Hide resolved
@sarah-thong
Copy link
Collaborator

sarah-thong commented Jan 14, 2025 •
edited
Loading

Other Comments

  • Pls sync your branch to the latest master.

  • Pls don't forget to add documentation for the added field. If you need a reference on what to add and how to add it, pls do a global search for blacklisted_markets in demex-webapp-config on Visual Studio Code. This will show all the different files to add docs to.
    image

sarah-thong
sarah-thong reviewed Feb 5, 2025
View reviewed changes
configs/mainnet.json Outdated
"decimals": 6
},
"Noble": {
"denom": "usdc.1.6.53ff75",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Noble, the correct denom is ibc/43897B9739BD63E3A08A88191999C632E052724AB96BD4C74AE31375C991F48D.

configs/mainnet.json Outdated
"decimals": 18
},
"Arbitrum": {
"denom": "brdg/e3877e2c8ed05e404e04417747e2f430285c11dc839663b943b39ff7cbb56377",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Arbitrum, denom should be brdg/1299d2e94c483e72f64100088886b8a5b7c13595047e53e032c9938d07a98c20

configs/mainnet.json Outdated
"decimals": 8
},
"Optimism": {
"denom": "brdg/e3877e2c8ed05e404e04417747e2f430285c11dc839663b943b39ff7cbb56377",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Optimism, denom should be brdg/34a330df380acf4845e3c3341722a73cc62b57819a2e9960fbb0e040a5210423

configs/testnet.json
"fee_denom": "brdg/a493620f7d356bb7fee3a5ea8511d70d5ac728232cc5fe4a25dbd8028993a0e7",
"decimals": 18
}
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, think Carbon Testnet was just reseeded. Could you change the following:

  • Binance Smart Chain => BSC testnet
  • brdg/a493620f7d356bb7fee3a5ea8511d70d5ac728232cc5fe4a25dbd8028993a0e7 => brdg/058df3a0734c28f905ea8a9ce7f8183a6f76fb10ed1b8cf70acb5f697f5d7009

@sarah-thong
Copy link
Collaborator

sarah-thong commented Feb 5, 2025 •
edited by GulfOfAlaska
Loading

Other Comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-thong sarah-thong sarah-thong left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GulfOfAlaska @sarah-thong