From a2fb8a7e7a894444de3bdf2569439ef12575ed20 Mon Sep 17 00:00:00 2001
From: thanhpn <ngocthanh2207@gmail.com>
Date: Tue, 21 Jan 2025 10:41:20 +0700
Subject: [PATCH] Address reviewer comments

---
 .github/markets/pr_template.md |  8 ++++----
 README.md                      |  2 +-
 config.schema.json             | 10 +++++-----
 configs/mainnet.json           | 10 +++++-----
 4 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/.github/markets/pr_template.md b/.github/markets/pr_template.md
index 7312f35..cba3fc0 100644
--- a/.github/markets/pr_template.md
+++ b/.github/markets/pr_template.md
@@ -30,7 +30,7 @@ Each json file under the [configs](../../configs) folder correspond to their res
 |`quick_select_tokens`   |`QuickSelectToken[]`   |true   |List of quick select tokens for deposit and withdrawal forms.   |
 |`disabled_transfer_banner_config` |`DisabledTransferBannerConfig` |false |Config parameters for displaying banner to inform users that transfers for the relevant tokens are disabled |
 |`trading_leagues`   |`TradingLeague[]`   |false   |Map of trading league config with their path.   |
-|`nitron_native_aprs`   |`NitronNativeAPR[]`   |true   |List of Nitron native APR APIs.   |
+|`lst_native_aprs`   |`LSTNativeAPR[]`   |true   |List of LST native APR APIs.   |
 
 ## Maintenance Data Structure
 |Field   |Type   |Required   |Description   |Notes   |
@@ -148,10 +148,10 @@ Each json file under the [configs](../../configs) folder correspond to their res
 |`trading_league`   |`string`   |true   |The trading league name    |
 |`trading_league_title`   |`string`   |true   |The trading league title    |
 
-## NitronNativeAPR Data Structure
+## LSTNativeAPR Data Structure
 |Field   |Type   |Required   |Description   |Notes   |
 |---|---|---|---|---|
 |`protocol`   |`string`   |true   |The protocol name    |
-|`api_url`   |`string`   |true   |The API URL for fetch APR info    |
-|`reward_denom`   |`object`   |true   |The key value object for mapping symbol and denom    |
+|`api_url`   |`string`   |true   |The API to fetch LST Native APR    |
+|`lst_denoms`   |`object`   |true   |The key value object for mapping denom of protocol api and carbon lst denom    |
 
diff --git a/README.md b/README.md
index fcf15ba..43b3073 100644
--- a/README.md
+++ b/README.md
@@ -15,7 +15,7 @@ Currently, each JSON file contain the following data on its corresponding networ
 - map of IBC channels for external IBC chains (such as Osmosis, Noble, etc.)
 - information about IBC tokens that are not added on chain or require packet forwarding
 - default quick select tokens in deposit/withdrawal forms
-- Nitron Native APR API config for get APR show on Nitron markets
+- LSTs native apr config to show on Nitron markets
 
 Additionally, the JSON file for mainnet contains the following data to support ongoing campaigns/promotions:
 - demex points config
diff --git a/config.schema.json b/config.schema.json
index 711d29a..267e9b4 100644
--- a/config.schema.json
+++ b/config.schema.json
@@ -633,9 +633,9 @@
         "$ref": "#/$defs/trading_league"
       }
     },
-    "nitron_native_apr": {
+    "lst_native_apr": {
       "type": "object",
-      "description": "API for query native APR on Nitron",
+      "description": "API for query LST native APR show on Nitron",
       "required": ["label_denom", "target_denom"],
       "properties": {
         "protocol": {
@@ -652,11 +652,11 @@
         }
       }
     },
-    "nitron_native_aprs": {
+    "lst_native_aprs": {
       "type": "array",
-      "description": "List of APIs for native APR on Nitron",
+      "description": "List of APIs for fetch LST Native APR show on Nitron",
       "items": {
-        "$ref": "#/$defs/nitron_native_apr"
+        "$ref": "#/$defs/lst_native_apr"
       }
     }
   }
diff --git a/configs/mainnet.json b/configs/mainnet.json
index d7841e4..3391c2a 100644
--- a/configs/mainnet.json
+++ b/configs/mainnet.json
@@ -505,18 +505,18 @@
       "trading_league_title": "Base Trading League"
     }
   },
-  "nitron_native_aprs": [
+  "lst_native_aprs": [
     { 
       "protocol": "Drop",
       "api_url": "https://app.drop.money/api/apy",
-      "reward_denom": {
+      "lst_denoms": {
         "dATOM": "ibc/EF37C83E78BD1F9B2401B3B3E5C00E0DBA71A648E2A8C3018861786F7A5F0105"
       }
     },
     {
       "protocol": "Stride",
       "api_url": "https://edge.stride.zone/api/stake-stats",
-      "reward_denom": {
+      "lst_denoms": {
         "ATOM": "ibc/A4DB47A9D3CF9A068D454513891B526702455D3EF08FB9EB558C561F9DC2B701",
         "OSMO": "ibc/ED07A3391A112B175915CD8FAF43A2DA8E4790EDE12566649D0C2F97716B8518",
         "STARS": "ibc/C688EBE80ECC20865331A18D8D19654754F6B189977715FED00FBA2BE41F144F",
@@ -532,14 +532,14 @@
     {
       "protocol": "Lido",
       "api_url": "https://eth-api.lido.fi/v1/protocol/steth/apr/sma",
-      "reward_denom": {
+      "lst_denoms": {
         "wstETH": "brdg/6901fa9eb45ef8351c0ab9e29fa45da3bb0538bfbc5a84ad1009e3544346d2c8"
       }
     },
     {
       "protocol": "MilkyWay",
       "api_url": "https://apis.milkyway.zone/v2/protocols/osmosis.milkTIA",
-      "reward_denom": {
+      "lst_denoms": {
         "milkTIA": "ibc/16065EE5282C5217685C8F084FC44864C25C706AC37356B0D62811D50B96920F"
       }
     }