Address reviewer comment

Switcheo · Dec 12, 2024 · 48f54a6 · 48f54a6
1 parent f3c875e
commit 48f54a6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/configs/devnet.json b/configs/devnet.json
@@ -39,6 +39,6 @@
     }
   ],
   "spot_pool_config": {
-    "show_apr_tooltip": true
+    "show_apr_tooltip": false
   }
 }
diff --git a/configs/testnet.json b/configs/testnet.json
@@ -53,6 +53,6 @@
     "domain": "https://test-dagger.dem.exchange"
   },
   "spot_pool_config": {
-    "show_apr_tooltip": true
+    "show_apr_tooltip": false
   }
 }
diff --git a/scripts/check_configs.ts b/scripts/check_configs.ts
@@ -31,7 +31,7 @@ interface ConfigJSON {
   wswth_contract?: string;
   market_banners?: MarketBanner[];
   market_promo?: {[marketId: string]: MarketPromo};
-  spot_pool_config: SpotPoolConfig;
+  spot_pool_config?: SpotPoolConfig;
 }
 
 interface InvalidEntry {
@@ -337,7 +337,7 @@ function isValidMarketPromo(marketPromo: {[marketId: string]: MarketPromo}, netw
       outcomeMap[network] = false;
     }
 
-    for (const promoId in marketPromoIds) {
+    for (const promoId of marketPromoIds) {
       const promoInfo = marketPromo[promoId];
       const startTimeStr = promoInfo.start;
       const endTimeStr = promoInfo.end;