Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useRetimer): improve timerId typing #29

Closed
wants to merge 2 commits into from
Closed

fix(useRetimer): improve timerId typing #29

wants to merge 2 commits into from

Conversation

kyle1an
Copy link
Contributor

@kyle1an kyle1an commented Jan 1, 2025

Avoid Typescript throws an error: Type 'Timer' is not assignable to type 'number'.
https://stackoverflow.com/questions/51040703/what-return-type-should-be-used-for-settimeout-in-typescript

SukkaW
SukkaW requested changes Jan 2, 2025
View reviewed changes
Copy link
Owner

@SukkaW SukkaW left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type mismatch is caused by @types/node and it has nothing to do with foxact. Raise the issue to @types/node instead.

@kyle1an
Copy link
Contributor Author

kyle1an commented Jan 2, 2025

The type mismatch is caused by @types/node and it has nothing to do with foxact. Raise the issue to @types/node instead.

Thanks for the feedback and the direction. I'll close this PR.

@kyle1an kyle1an closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle1an @SukkaW