Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for version 0.6 #22

Merged
merged 7 commits into from
Dec 21, 2023
Merged

Prepare for version 0.6 #22

merged 7 commits into from
Dec 21, 2023

Conversation

dilawar
Copy link
Contributor

@dilawar dilawar commented Dec 20, 2023

It is a major rewrite. Major changes are

  • Removed pop and remove apis.
  • As soon as a data point is pushed, the statistics are computed.
  • Most fields are private.
  • Rely on watermill crate for underlying computations. It is much better tested.
  • Changes to new, default and with_fixed_capacity APIs.
  • Underlying Vec is replaced by VecDeque

cc: @purnatag

@dilawar dilawar requested a review from sn99 December 20, 2023 09:10
src/lib.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@purnatag
Copy link
Contributor

It is a major rewrite. Major changes are

  • Removed pop and remove apis.
  • As soon as a data point is pushed, the statistics are computed.
  • Most fields are private.
  • Rely on watermill crate for underlying computations. It is much better tested.
  • Changes to new, default and with_fixed_capacity APIs.
  • Underlying Vec is replaced by VecDeque

cc: @purnatag

@dilawar I was wondering about a more meta issue -- if we are using watermill for all the computations, does that not invalidate the reason of existence of SimpleAccumulator as a public github repo, since we have not added any novelty?

@dilawar
Copy link
Contributor Author

dilawar commented Dec 21, 2023

@dilawar I was wondering about a more meta issue -- if we are using watermill for all the computations, does that not invalidate the reason of existence of SimpleAccumulator as a public github repo, since we have not added any novelty?

Yes. I haven't added anything new except an easier API. This is more tested and I can use it today and move on to unsolved problems. We can re-invent the wheel later (but why?). I'll still have to add more computations #23 etc.

@dilawar dilawar merged commit 2a13914 into master Dec 21, 2023
2 checks passed
@dilawar dilawar deleted the issue_19 branch December 21, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants