Loki shooter + Coral Funnel Subsystem #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Calvin Ye <cye2007@users.noreply.github.com> Co-authored-by: Jerry Jiang <JerryJiang531@users.noreply.github.com> Co-authored-by: LinAndy10 <LinAndy10@users.noreply.github.com> Co-authored-by: Weifen Chen <WennieC@users.noreply.github.com> Co-authored-by: Rahul Deb <rahuldeb.usa@gmail.com>
only calls set rpm at the end
Moved the shooter rpm commands to the abstract class
… targetRPM Co-authored-by: Calvin Ye <cye2007@users.noreply.github.com> Co-authored-by: sixuanl <sixuanl@users.noreply.github.com> Co-authored-by: ryanyu32 <ryanyu32@users.noreply.github.com> Co-authored-by: metereel <Material-Energy@users.noreply.github.com> Co-authored-by: LinAndy10 <LinAndy10@users.noreply.github.com>
Co-authored-by: Weifen Chen <WennieC@users.noreply.github.com> Co-authored-by: Rahul Deb <rahuldeb.usa@gmail.com>
Readded stopping functionality back to funnel default command renamed changeState to runState in default command for clarity removed this in all methods changed detectCurrentSpike to private
k4limul
reviewed
Feb 3, 2025
|
|
||
| @Override | ||
| public void initialize(){ | ||
| if (shooter.hasAlgae()){ |
There was a problem hiding this comment.
remove algae scoring front/back
k4limul
reviewed
Feb 3, 2025
|
|
||
| // Set values later | ||
| public interface Shooter { | ||
| int MOTOR = 0; |
There was a problem hiding this comment.
shooter = rename to receiver port
funnel = rename to IR
k4limul
reviewed
Feb 3, 2025
| public interface Settings {} | ||
| public interface Settings { | ||
| public interface Shooter { | ||
| SmartNumber ALGAE_FRONT_SPEED = new SmartNumber("Algae Target Speed", 1); |
k4limul
reviewed
Feb 3, 2025
|
|
||
| public interface Funnel { | ||
| SmartNumber MOTOR_SPEED = new SmartNumber("Funnel Speed", 0.0); | ||
| double BB_DEBOUNCE = 0.0; |
Changed motorBeam on shooter to receiver Changed motorBeam on funnel to ir Removed front and back shooting for algae, changed to just shooting Fixed bug where coral acquired in the wrong direction
|
GG |
k4limul
approved these changes
Feb 3, 2025
k4limul
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.