Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated header and footer #2 #20

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Rushhaabhhh
Copy link

Screenshot 2024-10-01 174201

Please review the UI changes and let me know if any further adjustments are needed.

Copy link

vercel bot commented Oct 1, 2024

@Rushhaabhhh is attempting to deploy a commit to the My Projects Team on Vercel.

A member of the Team first needs to authorize it.

@Rushhaabhhh Rushhaabhhh changed the title Updated header and footer Updated header and footer #2 Oct 1, 2024
@StephCurry07
Copy link
Owner

Tbh, the footer is not looking nice....also do you think it's looking good in black?
The logo's etherwheels not displayed due to both dark...ether is darkblue-purple and header is black.
Could you either change the logo or make the header a bit different.
And remove the footer coz it's also engaging with the open assistant button...and also not looking good.

@Rushhaabhhh
Copy link
Author

image
@StephCurry07 I have updated the header and removed the footer, please review the changes.

@StephCurry07
Copy link
Owner

umm... previous one looks better... can you change the logo...
also can you combine the change role and current role. Can be adjusted in single nav item

@Rushhaabhhh
Copy link
Author

image

@StephCurry07 As you asked I have updated the header, please review the changes.

@StephCurry07
Copy link
Owner

Shift it to right side...where the change role originally was and do like
Change role(Passenger) or changerole(driver) whatever the current role is...the button would work as it was doing earlier. and youre good to go

@Rushhaabhhh
Copy link
Author

image

Changes made

@Rushhaabhhh
Copy link
Author

@StephCurry07 Any updates on the PR ?

@StephCurry07
Copy link
Owner

Yea I need to test it....Also look at the font pls. Make sure it's uniform.

@StephCurry07
Copy link
Owner

Change the font size... and remove the change role dropdown on click. Once the user clicks he gets redirected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants