Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some comments on the website #196

Open
mashfiqui-rabbi opened this issue Nov 30, 2020 · 1 comment
Open

Some comments on the website #196

mashfiqui-rabbi opened this issue Nov 30, 2020 · 1 comment
Assignees
Labels
harvard-dev Harvard specific SARA version

Comments

@mashfiqui-rabbi
Copy link
Collaborator

  1. Add a comment on how this page is structured. This will be very useful for others who are not familiar with Bootstrap. This doesn't have to exhaustive; just a link for people so that they can learn. e.g., the "Home" is the top of the page which is divided into two columns. "twoFatCols" css creates two columns.

    <div class=twoFatCols>

  2. Then we can write a comment for "saraTitle," this is the left column of the home page.

    <h1 id=saraTitle>SARA</h1>

  3. Can we use the following variable names: "twitter_time_line" --> "Timeline", "pageBody" --> "style_for_twitter_timeline_body", "pageTitle" --> "style_for_twitter_timeline_header".

    <div id=Timeline>

If you want to use the same style for different parts of the page then we can use a generic name (big header or two_fat_column that you used.)

4. After reading the code a bit, I felt like the code would be more readable if use a snake notation. Chloe, what do you think?

@mashfiqui-rabbi mashfiqui-rabbi added the harvard-dev Harvard specific SARA version label Nov 30, 2020
@ChloeL19
Copy link
Collaborator

Sounds great, Mash! I'll work on making these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
harvard-dev Harvard specific SARA version
Projects
None yet
Development

No branches or pull requests

2 participants