Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small improvements mostly on build system #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "library/XmlParser-CPP"]
path = library/XmlParser-CPP
url = https://github.com/olcaytaner/XmlParser-CPP.git
12 changes: 10 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
cmake_minimum_required(VERSION 3.12)

project(PropBank)

set(CMAKE_CXX_STANDARD 17)
include_directories(include)
link_directories(library)

add_subdirectory(library/XmlParser-CPP)

include_directories(library/XmlParser-CPP)

add_library(PropBank Argument.cpp Argument.h ArgumentType.h Role.cpp Role.h RoleSet.cpp RoleSet.h FramesetArgument.cpp FramesetArgument.h Frameset.cpp Frameset.h Predicate.cpp Predicate.h PredicateList.cpp PredicateList.h FramesetList.cpp FramesetList.h)

target_link_libraries(PropBank XmlParser)

add_executable(TestPropBank Argument.cpp Argument.h ArgumentType.h Role.cpp Role.h RoleSet.cpp RoleSet.h FramesetArgument.cpp FramesetArgument.h Frameset.cpp Frameset.h Predicate.cpp Predicate.h PredicateList.cpp PredicateList.h FramesetList.cpp FramesetList.h TestPropBank.cpp)

target_link_libraries(TestPropBank XmlParser)
1 change: 1 addition & 0 deletions Role.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include <utility>
#include <algorithm>

//
// Created by Olcay Taner Yıldız on 6.10.2018.
Expand Down
25 changes: 0 additions & 25 deletions include/XmlAttribute.h

This file was deleted.

34 changes: 0 additions & 34 deletions include/XmlDocument.h

This file was deleted.

40 changes: 0 additions & 40 deletions include/XmlElement.h

This file was deleted.

13 changes: 0 additions & 13 deletions include/XmlTextType.h

This file was deleted.

19 changes: 0 additions & 19 deletions include/XmlTokenType.h

This file was deleted.

1 change: 1 addition & 0 deletions library/XmlParser-CPP
Submodule XmlParser-CPP added at 6f6b2a
Binary file removed library/libXmlParser.a
Binary file not shown.