-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SpeziTesting library and migrate some tests to Swift Testing #122
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 87.44% 86.95% -0.48%
==========================================
Files 51 52 +1
Lines 1687 1693 +6
==========================================
- Hits 1475 1472 -3
- Misses 212 221 +9
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the work here!
Would be amazing to see if and how we can transition XCRuntimeAssertions
to support Swift Testing to transition the remaining tests. I am wondering what a good approach around this would look like; I created SwiftTestingExtensions a while and am wondering if this should move in there and/or if we just rename/update XCRuntimeAssertions to also support Swift Testing in a nice way?
I would probably rename XCTRuntimeAssertions to just RuntimeAssertions and make it support both XCTest and Swift Testing. Aiming to submit a PR for that soon. |
Sound like a great idea! |
Introduce SpeziTesting library and migrate some tests to Swift Testing
♻️ Current situation & Problem
This PR starts the effort of replacing XCTest with Swift Testing. We replaced the
XCTSpezi
library withSpeziTesting
. This can be adopted by anyone even if using with XCTest as just the naming semantics changed.Secondly, this PR already migrates some of the unit tests to use Swift Testing. Some remain unchanged as we also require the underlying XCTRuntimeAssertions to be updated.
⚙️ Release Notes
📚 Documentation
--
✅ Testing
--
📝 Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: