Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wait_for_instance_to_terminate in destroy_vm #367

Open
blag opened this issue Jan 28, 2019 · 0 comments
Open

Improve wait_for_instance_to_terminate in destroy_vm #367

blag opened this issue Jan 28, 2019 · 0 comments

Comments

@blag
Copy link
Contributor

blag commented Jan 28, 2019

In destroy_vm, instead of waiting for a specified period of time for an instance to terminate (in wait_for_instance_to_terminate), we should regularly query the status of the instance and wait for it to be stopped before continuing.

The 60 seconds we wait is not quite long enough for the CentOS 7 instances to completely shut down and have their disk volumes detach, so in some of the workflows on the new CI/CD server the subsequent delete_volumes failed with a "volume still in use" error.

We can simply increase the timeout, but that simply works around the problem, it doesn't fix it reliably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant