Pantsbuild: Make exported venv useful for running nose #6141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == certifi 2023.11.17 --> 2024.2.2 cryptography 42.0.1 --> 42.0.2 orjson 3.9.12 --> 3.9.13 pip 23.3.2 --> 24.0 platformdirs 4.1.0 --> 4.2.0 pytz 2023.4 --> 2024.1 ruamel-yaml 0.18.5 --> 0.18.6 urllib3 2.1.0 --> 2.2.0 voluptuous 0.14.1 --> 0.14.2 waitress 2.1.2 --> 3.0.0 == Added dependencies == colorama 0.4.6 nose 1.3.7 nose-parallel 0.4.0 nose-timer 1.0.1 rednose 1.3.0 termstyle 0.1.11
pull-request-size
bot
added
the
size/XL
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == cryptography 42.0.2 --> 42.0.3 gitpython 3.1.41 --> 3.1.42 netaddr 0.10.1 --> 1.1.0 orjson 3.9.13 --> 3.9.14 setuptools 69.0.3 --> 69.1.0 tzdata 2023.4 --> 2024.1 == !! Downgraded dependencies !! == mongoengine 0.27.0 --> 0.23.1 pymongo 4.6.1 --> 3.12.3
cognifloyd
force-pushed
the
pants-venv
branch
from
1bd00d7
to
8fae495
Compare
amanda11
approved these changes
Feb 19, 2024
winem
approved these changes
Feb 20, 2024
| @@ -45,7 +46,8 @@ prettytable | |||
| # For st2client: prompt-toolkit v2+ does not have prompt_toolkit.token.Token | |||
| prompt-toolkit<2 | |||
| psutil | |||
| pymongo | |||
| # pymongo 3.13 has backports of APIs from pymongo 4 to help w/ migration | |||
| pymongo>=3.11.0,<3.13.0 | |||
There was a problem hiding this comment.
So 3.13 comes already with breaking changes? I'll study their changelog to get a better understanding. Besides that the PR looks good!
There was a problem hiding this comment.
It at least has a bunch of deprecations that are likely to cause (many?) extra warnings in the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, you can run
pants export --resolve=st2to get a venv underdist/export/python/virtualenvs/st2/<python version>. The venv includes:lockfiles/st2.lock:noseso that you can run the tests.pymongoandmongoenginethat is compatible with our codePex (used by pants) will create the venv with the first interpreter on the path that matches the interpreter_constraints in pants.toml. If you want to generate a venv with a particular python binary use this:
Replace
/usr/bin/python3.9with the interpreter you want pants to use.This PR does not attempt to get the Makefile to use the venv. This PR just extracts the bits I'm confident about from #6130.
Summary of changes in the Lockfile: