Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get-dependencies option to install_pack.py #5994

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jk464
Copy link
Contributor

@jk464 jk464 commented Jun 21, 2023

Enhances install_pack.py so that you can pass an optional flag to it (--get-dependencies) that will for a given pack when it is installed will also install any other packs the parent pack depdends on it.

Useful when using https://github.com/StackStorm/st2packs-dockerfiles/ to build a st2packs image, the user only has to provide the list of packs they want, without having to determine if they have any further packs as depdencies.

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Jun 21, 2023
@guzzijones
Copy link
Contributor

needs a changelog entry

@jk464
Copy link
Contributor Author

jk464 commented Aug 15, 2023

@guzzijones I've added a Changelog entry now

Copy link
Contributor

@guzzijones guzzijones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple small adjustments. Thanks for your contribution.

st2common/st2common/cmd/install_pack.py Outdated Show resolved Hide resolved
st2common/st2common/cmd/install_pack.py Show resolved Hide resolved
st2common/st2common/cmd/install_pack.py Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines. Requires some effort to review. and removed size/M PR that changes 30-99 lines. Good size to review. labels Aug 23, 2023
Copy link
Contributor

@guzzijones guzzijones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature size/L PR that changes 100-499 lines. Requires some effort to review.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants