Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackStorm Packs - Support for Git Submodules #5963

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jk464
Copy link
Contributor

@jk464 jk464 commented Apr 21, 2023

StackStorm Packs are implemented as Git Repos. Currently when pack install is run, submodules contained within packs are not handled.

This PR implements the checkout_submodules option on pack install (and pack download etc) so that when pack install is ran a user can optionally set this option to True to checkout submodules as part of the install process.

The option defaults to False to maintain current behaviour of the pack install process and thus backwards complatibity with pre-exisiting processes.

Implements #5814

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Apr 21, 2023
@CLAassistant
Copy link

CLAassistant commented Apr 21, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@guzzijones
Copy link
Contributor

please sign the cla

@guzzijones
Copy link
Contributor

oh looks like this just needs a review and a milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature size/M PR that changes 30-99 lines. Good size to review.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants