Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement to process_container.py #5902

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

luckenbach
Copy link

Why

#4928

How

Per @guzzijones's recommendation logic needed to be added to cycle the sensor if the token is expired based of the TTL of the token

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Feb 14, 2023
@CLAassistant
Copy link

CLAassistant commented Feb 14, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Zach Hilliard seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@luckenbach luckenbach changed the title WIP: Enhancement to process_container.py Enhancement to process_container.py Feb 16, 2023
@amanda11
Copy link
Contributor

As per comments in #4928 I'd like to see why the existing code to refresh the token isn't working.
There is logic to refresh the token as long as we access via the sensor_service, which in turn calls the get_api_key in the datastore.py (which is where the refresh logic is).
In the example of where this fails, are we trying to access the api client without going through the sensor_service methods? If so, why? Do we need to add more methods to sensor_service instead, so that you can benefit from the refresh key code in there.
OR have we got a bug in that refresh code.

@guzzijones
Copy link
Contributor

The fact that we restart the service to create a new token is not ideal. yes we 'refresh' the token, but the way we do it isn't the cleanest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants