Skip to content

fix(snippets-btn): Minor styling/a11y fixes #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dancormier
Copy link
Contributor

@dancormier dancormier commented Apr 28, 2025

This PR makes the following updates to the "Run code snippets" button:

  • remove redundant a11y-related attributes
  • render as inline-flex to allow proper centering of child elements
  • add a 2px gap for a little space between the icon and text

Before

image

After

image

Copy link

changeset-bot bot commented Apr 28, 2025

🦋 Changeset detected

Latest commit: 6486008

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stackoverflow/stacks-editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for stacks-editor ready!

Name Link
🔨 Latest commit 74a99a2
🔍 Latest deploy log https://app.netlify.com/sites/stacks-editor/deploys/680fe071ff6bff0008e7bc2a
😎 Deploy Preview https://deploy-preview-434--stacks-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for stacks-editor ready!

Name Link
🔨 Latest commit 6486008
🔍 Latest deploy log https://app.netlify.com/sites/stacks-editor/deploys/680fe2d1314652000866dbe1
😎 Deploy Preview https://deploy-preview-434--stacks-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dancormier dancormier requested a review from threefjefff April 28, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant