Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Use bigint for long types in mcdoc #1487

Merged
merged 4 commits into from
Jan 2, 2025
Merged

♻️ Use bigint for long types in mcdoc #1487

merged 4 commits into from
Jan 2, 2025

Conversation

NeunEinser
Copy link
Contributor

No description provided.

@misode misode changed the title Use bigint for long types in mcdoc ♻️ Use bigint for long types in mcdoc Jul 7, 2024
misode
misode reviewed Jul 7, 2024
View reviewed changes
Copy link
Member

@misode misode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these unsafe casts make me a bit nervous, but I don't immediately see a clean way to get rid of them

packages/mcdoc/src/runtime/checker/index.ts Show resolved Hide resolved
packages/mcdoc/src/binder/index.ts Show resolved Hide resolved
@misode misode merged commit da865cd into SpyglassMC:main Jan 2, 2025
3 checks passed
misode added a commit that referenced this pull request Jan 4, 2025
@misode
⏪️ Revert "♻️ Use bigint for long types in mcdoc (#1487)"
2c69062 
This reverts commit da865cd.
@misode
Copy link
Member

misode commented Jan 4, 2025

I had to revert this, because this caused issues when saving the symbols in the cache file. I don't see a button to reopen the PR, so you might need to open a new PR when we have a fix for this.

[Error - 1:04:51 AM] [CacheService#save] path = file:///<CACHE>/symbols/d354ae857b06ee874f712c28b13436746cebac42.json.gz TypeError: Do not know how to serialize a BigInt
    at JSON.stringify (<anonymous>)
    at Object.writeGzippedJson (<SOURCE>\packages\core\src\service\fileUtil.ts:321:49)
    at CacheService.save (<SOURCE>\packages\core\src\service\CacheService.ts:234:19)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misode misode misode left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeunEinser @misode