♻️ Use bigint for long types in mcdoc #1487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misode
changed the title
misode
reviewed
Jul 7, 2024
| @@ -498,7 +500,8 @@ function checkShallowly<T>( | |||
| if ( | |||
| typeDef.valueRange | |||
| && simplifiedInferred.kind === 'literal' | |||
| && typeof simplifiedInferred.value.value === 'number' | |||
| && simplifiedInferred.value.kind !== 'string' | |||
| && simplifiedInferred.value.kind !== 'boolean' | |||
There was a problem hiding this comment.
There are probably a few other places, maybe in attributes, where this pattern was used
There was a problem hiding this comment.
Pretty sure that's untrue. This one I cought because it caused a build error, so I don't see why this wouldn't happen in other places.
| @@ -1001,7 +1009,7 @@ function convertLiteralValue(node: LiteralTypeValueNode, ctx: McdocBinderContext | |||
| kind: convertLiteralNumberSuffix(suffix, ctx) | |||
| ?? (value.type === 'integer' ? 'int' : 'double'), | |||
| value: value.value, | |||
| } | |||
| } as LiteralValue | |||
There was a problem hiding this comment.
This PR adds a couple of these unsafe casts, if you find a way to get rid of them that would be nice
There was a problem hiding this comment.
In some places, you can do
return kind === 'long'
? { kind, value }
: { kind, value }to satisfy the type checker, but it's also a bit weird ¯\_(ツ)_/¯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.