🐛 Fix item_predicate command argument in 1.21.5

SpyglassMC · Jan 29, 2025 · e87f791 · e87f791
1 parent 7bf59b9
commit e87f791
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/java-edition/src/mcfunction/checker/index.ts b/packages/java-edition/src/mcfunction/checker/index.ts
@@ -140,7 +140,12 @@ const itemPredicate: core.SyncChecker<ItemPredicateNode> = (node, ctx) => {
 			} else if (ComponentTestExactNode.is(test) && test.value) {
 				nbt.checker.index('minecraft:data_component', key)(test.value, ctx)
 			} else if (ComponentTestSubpredicateNode.is(test) && test.value) {
-				nbt.checker.index('minecraft:item_sub_predicate', key)(test.value, ctx)
+				const release = ctx.project['loadedVersion'] as ReleaseVersion | undefined
+				if (release && ReleaseVersion.cmp(release, '1.21.5') < 0) {
+					nbt.checker.index('minecraft:item_sub_predicate', key)(test.value, ctx)
+				} else {
+					nbt.checker.index('minecraft:data_component_predicate', key)(test.value, ctx)
+				}
 			}
 		}
 	}

diff --git a/packages/java-edition/src/mcfunction/parser/argument.ts b/packages/java-edition/src/mcfunction/parser/argument.ts
@@ -1778,7 +1778,12 @@ const componentTest: core.InfallibleParser<ComponentTestNode> = (src, ctx) => {
 	if (src.trySkip('~')) {
 		src.skipWhitespace()
 		if (key.options.category !== undefined) {
-			key.options.category = 'item_sub_predicate_type'
+			const release = ctx.project['loadedVersion'] as ReleaseVersion | undefined
+			if (release && ReleaseVersion.cmp(release, '1.21.5') < 0) {
+				key.options.category = 'item_sub_predicate_type'
+			} else {
+				key.options.category = 'data_component_predicate_type'
+			}
 		}
 		const ans: ComponentTestSubpredicateNode = {
 			type: 'mcfunction:component_test_sub_predicate',