Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Debug for Logger #81

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Implement Debug for Logger #81

merged 1 commit into from
Jan 12, 2025

Conversation

Nicholas-Clavette
Copy link

Closes #80

SpriteOvO
SpriteOvO reviewed Jan 10, 2025
View reviewed changes
spdlog/src/logger.rs Outdated Show resolved Hide resolved
@SpriteOvO
Copy link
Owner

All concrete sinks are placed under directory ./spdlog/src/sink/, no hurry though, you can also implement for them in future PRs.

@Nicholas-Clavette
Copy link
Author

Okay, yeah - I can implement them in the future.

@SpriteOvO
Copy link
Owner

SpriteOvO commented Jan 11, 2025 •
edited
Loading

CI detected a format mismatch, you can run cargo fmt to fix that.

@SpriteOvO SpriteOvO force-pushed the impl-debug-for-logger branch 6 times, most recently from 680d6fb to b6fb228 Compare January 12, 2025 17:19
@SpriteOvO
Implement Debug for Logger
d87b1c7 
Co-authored-by: Asuna <SpriteOvO@gmail.com>
@SpriteOvO SpriteOvO force-pushed the impl-debug-for-logger branch from b6fb228 to d87b1c7 Compare January 12, 2025 17:22
@SpriteOvO SpriteOvO changed the base branch from main to main-dev January 12, 2025 17:24
SpriteOvO
SpriteOvO approved these changes Jan 12, 2025
View reviewed changes
Copy link
Owner

@SpriteOvO SpriteOvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SpriteOvO SpriteOvO merged commit 380c077 into SpriteOvO:main-dev Jan 12, 2025
33 checks passed
@SpriteOvO SpriteOvO mentioned this pull request Jan 12, 2025
Closed
SpriteOvO added a commit that referenced this pull request Jan 12, 2025
@Nicholas-Clavette @SpriteOvO
Implement Debug for Logger (#81)
65ccee3 
Co-authored-by: Nick Clavette <nclavette@aphysci.com>
Co-authored-by: Asuna <SpriteOvO@gmail.com>
@Nicholas-Clavette Nicholas-Clavette deleted the impl-debug-for-logger branch January 12, 2025 19:53
SpriteOvO added a commit that referenced this pull request Jan 20, 2025
@Nicholas-Clavette @SpriteOvO
Implement Debug for Logger (#81)
3b81097 
Co-authored-by: Nick Clavette <nclavette@aphysci.com>
Co-authored-by: Asuna <SpriteOvO@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpriteOvO SpriteOvO SpriteOvO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Implement Debug for Logger
2 participants
@Nicholas-Clavette @SpriteOvO