CI cargo clippy deny warnings for benches

SpriteOvO · Jun 12, 2024 · 214f40b · 214f40b
1 parent ada02cb
commit 214f40b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -77,16 +77,20 @@ jobs:
     - name: Install dependencies
       if: matrix.os == 'ubuntu-latest'
       run: sudo bash ./.github/workflows/install-deps.sh
-    - name: Install Rust nightly
+    - name: Install Rust nightly (stable date version)
       run: |
-        rustup toolchain install nightly
-        rustup component add clippy --toolchain nightly
+        STABLE_DATE=$(cargo clippy --version | perl -ne 'print $& if /\b\d{4}-\d{2}-\d{2}\b/')
+        echo "STABLE_DATE=$STABLE_DATE" >> $GITHUB_ENV
+
+        rustup toolchain install nightly-$STABLE_DATE
+        rustup component add clippy --toolchain nightly-$STABLE_DATE
     - name: Restore cargo caches
       uses: Swatinem/rust-cache@v1
     - name: Run clippy 
       run: cargo clippy --all-features --tests --examples -- -D warnings
     - name: Run clippy nightly for benches
-      run: cargo +nightly clippy --all-features --benches
+      run: |
+        cargo +nightly-${{ env.STABLE_DATE }} clippy --all-features --benches -- -D warnings
 
   check:
     strategy:

diff --git a/spdlog/benches/common/mod.rs b/spdlog/benches/common/mod.rs
@@ -9,6 +9,7 @@ use std::{
 
 use once_cell::sync::Lazy;
 
+#[allow(dead_code)]
 pub static BENCH_LOGS_PATH: Lazy<PathBuf> = Lazy::new(|| {
     let path = Path::new(env!("OUT_DIR")).join("bench_logs");
     if !path.exists() {

diff --git a/spdlog/benches/spdlog-rs/pattern.rs b/spdlog/benches/spdlog-rs/pattern.rs
@@ -6,7 +6,7 @@ use std::{cell::RefCell, sync::Arc};
 
 use paste::paste;
 use spdlog::{
-    formatter::{pattern, Formatter, FullFormatter, Pattern, PatternFormatter, RuntimePattern},
+    formatter::{pattern, Formatter, FullFormatter, Pattern, PatternFormatter},
     prelude::*,
     sink::Sink,
     Record, StringBuf,