Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single quotes get converted to double quotes #61

Open
Greenlamp2 opened this issue Apr 1, 2022 · 4 comments
Open

Single quotes get converted to double quotes #61

Greenlamp2 opened this issue Apr 1, 2022 · 4 comments
Labels
🐛 bug Something isn't working

Comments

@Greenlamp2
Copy link

Greenlamp2 commented Apr 1, 2022

When we upload an handler, it seems it auto-format the variables, meaning variable between single quotes becomes double quotes every time.

example with tiny tina's wonderland:

We upload:
var EpicArgs = 'PREFLIGHT_SCRIPT_WILL_REPLACE';

It becomes:
var EpicArgs = "PREFLIGHT_SCRIPT_WILL_REPLACE";

@Greenlamp2 Greenlamp2 changed the title Ability to conserve the single quote Ability to conserve the single quotes Apr 1, 2022
@Snailedlt Snailedlt added the 🐛 bug Something isn't working label Apr 1, 2022
@Snailedlt
Copy link
Member

Changing title to better fit a bug report

@Snailedlt Snailedlt changed the title Ability to conserve the single quotes Single quotes get converted to double quotes Apr 1, 2022
@Snailedlt
Copy link
Member

Snailedlt commented Jun 12, 2022

@Greenlamp2 Did you have an example for where this might ruin your code?
I vaguely remember you telling us your handler didn't work due to this bug

Edit:
If you could send me the entire handler, that would be best :)

@Snailedlt
Copy link
Member

The reason it's like this, is because we use prettier to prettify the code, so it's easier to read.

The code for it is here and here

@Snailedlt
Copy link
Member

@Talos910 Do you know of any examples where this can ruin handlers? If not, I prefer to have it formatted like this, so that the handlers are easier to read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants