Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digitalWriteFast is broken on most platforms... #884

Open
WestfW opened this issue Oct 24, 2024 · 0 comments
Open

digitalWriteFast is broken on most platforms... #884

WestfW opened this issue Oct 24, 2024 · 0 comments

Comments

@WestfW
Copy link
Contributor

WestfW commented Oct 24, 2024

It looks like digitalWriteFast (in Arduino.h) has some cut&paste errors, for example:

    if (val == LOW) {
      *out &= ~mask;                  // 1/1
    } else {                          // 1/1
      *out &= ~mask;                  // 1/1
    }   // and we know which one at compile time, so

This causes it to always set the pin LOW, regardless of arguments.
See (by .lst file inspection) on t85 and t84, but it looks like even more are broken.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant