Step Status Change Workflow Exception

[stevelipinski]

Description

When a Step is configured with a Status Change Workflow, and that workflow is not automatically persisted - an exception is thrown each time the Workflow is fired by the step.
Note: Workflow still appears to have been run.

Actual Behavior

Step Configured with Status Change-based Workflow. Workflow does not have Automatically Persist checked. Exception is thrown when Step fires off the workflow:
LaunchStepChangeWorkflows failed. Workflow instance could not be created [WorkflowName=Status Changed].

Note: Workflow still appears to have been run.

Expected Behavior

• If a Persisted workflow is required, it should minimally be documented, but also prevented from being configured. Or, a warning box of the same when the user attempts to configure the Step workflow
• No exceptions should be thrown, it should be handled properly and logged or prevent user from configuring as such

Steps to Reproduce

• Go to Steps - https://rock.rocksolidchurchdemo.com/people/steps
• Select Discipleship Path, then Baptism. Click Edit. - https://rock.rocksolidchurchdemo.com/steps/type/1
• Expand Workflows panel. Click + to add new WF. Set Launch Workflow When: Status Changed; Workflow Type: Samples->Landing Page (it's a default/sample w/o persistence). Save. Save.
• On Baptism Steps Page. Click + to add new Baptism Step. Set Person, Date, and Status: In Progress. Save.
• On Baptism Steps Page. Select the created Step for editing. Click Edit. Change Status: Complete. Save.
• View Exception log. Exception will have occurred - https://rock.rocksolidchurchdemo.com/admin/system/exceptions

LaunchStepChangeWorkflows failed. Workflow instance could not be created [WorkflowName=Status Changed].

Note: Workflow still appears to have been run. Landing Page WF in the above steps may not be the best to determine if the WF is run since there is no other evidence - a different WF may be needed to test that, but on our instance, the WF does seem to accomplish what it's coded to do.

As a workaround, we have enabled Automatically Persist on all or Step-triggered WFs.

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Reproduced the problem on a fresh install or on the demo site.

Rock Version

16.6, 16.2

Client Culture Setting

en-US