Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Readme.md for Chinese. #542

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

bdim404
Copy link

@bdim404 bdim404 commented May 14, 2024

I've added a full Chinese version!

@SpacingBat3
Copy link
Owner

SpacingBat3 commented May 15, 2024

I kinda felt uneasy about translating official docs, mostly because I wanted them to be maintained only by actual project maintainers and kept up-to-date. And given how fast WebCord does really change, it's easy for the docs to be actually outdated; I think even Polish official docs are out of sync right now with the English version and for those I've only translated.

I guess might reconsider this a bit. Maybe I'll do simple checks before merging it (in case of docs), like with Google Translate or sth...

Also, for some reason, I have a feeling that projects in general with Chinese docs are perceived like they are allowed for conversation to be made in Chinese (possibly due to my interest in Android modding community, which tends to be flooded with the maintainers from Asian countries) . I'm kinda uneasy with that fact (I don't really know Chinese, I guess that should be obvious by looking at the commits / repo at the current state); please add a disclaimer (if you didn't; I hardly checked the translation for now) that those docs are maintained by the community, they might be outdated and that you should prefer communicating in English with the maintainers (me).

@bdim404
Copy link
Author

bdim404 commented May 15, 2024

Don't worry, I'll gradually keep following up on the translation.

And I will add a disclaimer!

Copy link
Owner

@SpacingBat3 SpacingBat3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall translation looks fine and passes Google translate test well. I would still modify some things and I'd love to have some things explained before I'll pull this.

Comment on lines +8 to +10
<td>
<b>免责声明。</b>这些文档由社区维护,可能已经过时,而且您最好用英语与维护者交流。
</td>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to create a copy of the HTML table, and go with something like alert-info as a class value to style it properly. This is kinda non-MD / custom styling I use in WebCord docs, yet I might go with GH markdown alerts in the future, since those were recently announced and seem to be somewhat stabilized + marked already supports it / has an extension to introduce support for it.

Comment on lines +13 to +15
<p align='right'><sub>
English<a href='../Readme.md' title='English Readme'>Here</a>。
</sub></p>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better English and emoji? (See Polish docs for template on it)

Comment on lines 12 to +17
<p align='right'><sub>
Znasz 🇵🇱? Przejdź <a href='pl/Readme.md' title='Polski plik README'>tutaj</a>.
</sub></p>
<p align='right'><sub>
简体中文,请点击<a href='zh/Readme.md' title='zh-ch README'>这里</a>.
</sub></p>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would update this whole section, making it somewhat a combo of flag / language name (or just flag), just so it would be more fitting for multiple languages without taking a lot of the space.

Comment on lines +6 to +11
"one":"提及",
"other":"提及",
"zero": "",
"two": "",
"few":"",
"many":""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you confirm that Chinese plural rules are the same like in English? Do you have any other rules in some cases, like for little number of things vs large amount (this happens in some languages for instance in Polish there's few and many rules, few are for numbers/digits like 2,3,4 and many describes form for basically other set of numbers/digits)? If you're unsure on that, you might as well verify it in the practice; WebCord will automatically use the rules from this config for the number that is placed before the translation.

@SpacingBat3 SpacingBat3 added the type:L10N Issue or pull request associated with WebCord's localization files label Aug 17, 2024
@SpacingBat3 SpacingBat3 added this to the v4.10.1 milestone Aug 17, 2024
@SpacingBat3 SpacingBat3 modified the milestones: v4.10.1, v4.10.2 Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:L10N Issue or pull request associated with WebCord's localization files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants