Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bard] various changes and updates #201

Merged
merged 4 commits into from
Dec 26, 2023
Merged

[Bard] various changes and updates #201

merged 4 commits into from
Dec 26, 2023

Conversation

JoshuaEstes
Copy link
Member

@JoshuaEstes JoshuaEstes commented Dec 22, 2023 •
edited
Loading

Description

Closes #26 #29

Checklist

  • Updated CHANGELOG files
  • Updated Documentation
  • Unit Tests Created
  • php-cs-fixer

@github-actions github-actions bot added the bard label Dec 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023 •
edited
Loading

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (1fd79bb) 74.03% compared to head (e522192) 72.80%.
Report is 2 commits behind head on main.

Files Patch % Lines
.../SonsOfPHP/Bard/src/Console/Command/AddCommand.php 0.00% 19 Missing ⚠️
...onsOfPHP/Bard/src/Console/Command/MergeCommand.php 0.00% 17 Missing ⚠️
...SonsOfPHP/Bard/src/Console/Command/CopyCommand.php 0.00% 16 Missing ⚠️
...ker/File/Composer/Root/UpdateRequireDevSection.php 0.00% 12 Missing ⚠️
...SonsOfPHP/Bard/src/Console/Command/PushCommand.php 0.00% 10 Missing ⚠️
...onsOfPHP/Bard/src/Console/Command/SplitCommand.php 0.00% 10 Missing ⚠️
...SonsOfPHP/Bard/src/Console/Command/InitCommand.php 0.00% 3 Missing ⚠️
...sOfPHP/Bard/src/Console/Command/ReleaseCommand.php 0.00% 2 Missing ⚠️
src/SonsOfPHP/Bard/src/JsonFile.php 0.00% 1 Missing ⚠️
...sOfPHP/Bard/src/Worker/File/Bard/UpdateVersion.php 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #201      +/-   ##
============================================
- Coverage     74.03%   72.80%   -1.24%     
- Complexity     1309     1359      +50     
============================================
  Files           207      207              
  Lines          3247     3302      +55     
============================================
  Hits           2404     2404              
- Misses          843      898      +55

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaEstes JoshuaEstes changed the title various changes and updates [Bard] various changes and updates Dec 26, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 26, 2023
@JoshuaEstes JoshuaEstes marked this pull request as ready for review December 26, 2023 17:24
@JoshuaEstes JoshuaEstes added this pull request to the merge queue Dec 26, 2023
Merged via the queue into SonsOfPHP:main with commit b24d817 Dec 26, 2023
4 of 5 checks passed
@JoshuaEstes JoshuaEstes deleted the bard branch December 26, 2023 17:25
JoshuaEstes added a commit to JoshuaEstes/sonsofphp that referenced this pull request Jan 3, 2024
@JoshuaEstes
Merge branch 'main' into user_agent
37a4c9e 
* main:
  Housekeeping (SonsOfPHP#203)
  [EventDispatcher] Adding a few new things and working on docs (SonsOfPHP#202)
  [Bard] various changes and updates (SonsOfPHP#201)
  Adding Churn PHP as a tool in the repo (SonsOfPHP#200)
  Update symfony/phpunit-bridge requirement from ^6 to ^6 || ^7 (SonsOfPHP#192)
  [Mailer] New Component and Contract (SonsOfPHP#190)
  [Mailer] New Component and Contract (SonsOfPHP#189)
  House Keeping (SonsOfPHP#188)
  [HttpHandler] Component (SonsOfPHP#187)
  [Container] New Component (SonsOfPHP#182)
  [Cookie] New Component & Contract (SonsOfPHP#181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bard documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bard] Needs to track package names
2 participants
@JoshuaEstes @codecov-commenter