SLVS-1722 Log extra properties of SLCore log events #5924
+164
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgii-borovinskikh-sonarsource
requested a review
from gabriela-trutan-sonarsource
|
gabriela-trutan-sonarsource
approved these changes
Dec 27, 2024
| public string threadName; | ||
| public string loggerName; | ||
| // nullable | ||
| public string stackTrace; |
There was a problem hiding this comment.
We are missing the loggedAt property. Even if we don't use it for now, I think we should add it.
| @@ -34,25 +34,26 @@ public class LoggerListener : ILoggerListener | |||
| [ImportingConstructor] | |||
| public LoggerListener(ILogger logger) | |||
| { | |||
| this.logger = logger; | |||
| this.logger = logger.ForContext(SLCoreStrings.SLCoreName, SLCoreStrings.SLCoreInternalLogContext); | |||
There was a problem hiding this comment.
I think it's enough to add just one context that is a string of type "SlCore Logs". It would occupies less space than [SLCore > Logs].
| break; | ||
| } | ||
|
|
||
| if (parameters.stackTrace != null) |
There was a problem hiding this comment.
Move the null check inside the LogVerbose method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1722