Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVS-1738 Refactor ConnectionInformation #5919

Merged

Conversation

gabriela-trutan-sonarsource
Copy link
Contributor

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource commented Dec 23, 2024

SLVS-1738

Part of SLVS-1732

Refactor ConnectionInformation

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Refactor ConnectionInformation SLVS-1738 Refactor ConnectionInformation Dec 23, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment about a slightly confusing name

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource merged commit ab00890 into feature/hardening-q4 Dec 24, 2024
3 checks passed
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource deleted the gt/refactor-connection-info branch December 24, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants