SLVS-1718 Fix UI not updated after deleting connection #5906
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
| [TestMethod] | ||
| public async Task DisplayBindStatusAsync_WhenProjectWasBoundAndBecomesUnbound_UpdatesCurrentProjectAndBindingInfoToNull() | ||
| { | ||
| await InitializeBoundProject(); |
There was a problem hiding this comment.
Practically the InitializeBoundProject is doing nothing in this test, so as the WasBound part on the name.
This test can be merged with the one above (DisplayBindStatusAsync_WhenProjectIsNotBound_SelectedConnectionShouldBeEmpty) as they are testing the same things, and renamed to something like DisplayBindStatusAsync_WhenProjectIsNotBound_ClearsBinding.
There was a problem hiding this comment.
The two tests are not identical:
The InitializeBoundProject does something very important: initializes the view model propeties (SelectedConnectionInfo, SelectedProject, BoundProject) with objects whereas the other test sets them to null.
I will keep the test DisplayBindStatusAsync_WhenProjectIsNotBound_SelectedConnectionShouldBeEmpty, because it is a regression test, i.e. it will make sure that when we have a bound project and then unbind, the properties in the view model are set to null
There was a problem hiding this comment.
Removing the await InitializeBoundProject(); has the same result, the test passes. The InitializeBoundProject is irrelevant in this case.
|
SLVS-1718