SLVS-1697 Integrate Reproducer command with SLCore analysis #5905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgii-borovinskikh-sonarsource
force-pushed
the
gb/reproducer
branch
from
4df13d7 to
cf67fae
Compare
georgii-borovinskikh-sonarsource
requested a review
from gabriela-trutan-sonarsource
georgii-borovinskikh-sonarsource
marked this pull request as ready for review
gabriela-trutan-sonarsource
approved these changes
Dec 20, 2024
| @@ -182,6 +183,23 @@ public void ExecuteAnalysis_ForCFamily_PassesCompilationDatabaseAsExtraPropertie | |||
| compilationDatabaseHandle.Received().Dispose(); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
There was a problem hiding this comment.
Please also add a test case for when the reproducer is not enabled.
| @@ -164,6 +164,7 @@ private void TriggerReproducer() | |||
| { | |||
| var options = new CFamilyAnalyzerOptions | |||
| { | |||
| IsOnOpen = false, | |||
There was a problem hiding this comment.
Is this really needed? If so, I would add a comment explaining why (by default bool properties are initialized with false and if I would ever touch this code I will tend to remove the explicit initialization).
From my point of view adding a test case to catch if this value changes would be better.
| @@ -190,6 +190,7 @@ public void ExecuteAnalysis_CFamilyReproducerEnabled_SetsExtraProperty() | |||
| SetUpCompilationDatabaseLocator(filePath, CreateCompilationDatabaseHandle("somepath")); | |||
| SetUpInitializedConfigScope(); | |||
| var cFamilyAnalyzerOptions = Substitute.For<ICFamilyAnalyzerOptions>(); | |||
| cFamilyAnalyzerOptions.IsOnOpen.Returns(false); | |||
There was a problem hiding this comment.
Please extract the mock of ICFamilyAnalyzerOptions into a separate method to avoid creating too much noise in the test (lines 192-194)
|
georgii-borovinskikh-sonarsource
merged commit 5874542
into
feature/cfamily-migration
3 checks passed
georgii-borovinskikh-sonarsource
added a commit
that referenced
this pull request
Dec 24, 2024
georgii-borovinskikh-sonarsource
added a commit
that referenced
this pull request
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1697