Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVS-1705 Adapt AnalysisStatusNotifier to issue streaming #5899

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

georgii-borovinskikh-sonarsource
Copy link
Contributor

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource commented Dec 16, 2024

@@ -102,6 +102,8 @@ private async Task ExecuteAnalysisInternalAsync(
Dictionary<string, string> properties = [];
using var temporaryResourcesHandle = EnrichPropertiesForCFamily(properties, path, detectedLanguages);

Stopwatch stopwatch = Stopwatch.StartNew();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing stopwatch.Stop();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I confused that with the Timer.

Copy link
Contributor

@vnaskos-sonar vnaskos-sonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vnaskos-sonar vnaskos-sonar merged commit 044fcb8 into feature/cfamily-migration Dec 17, 2024
7 checks passed
@vnaskos-sonar vnaskos-sonar deleted the gb/streaming-logging branch December 17, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants