SLVS-1694 Provide system proxy settings to the SlCore process #5898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
georgii-borovinskikh-sonarsource
requested changes
Dec 17, 2024
| // no proxy was configured at system level | ||
| return null; | ||
| } | ||
| return new ProxyDto(ProxyType.HTTP, proxyUri.Host, proxyUri.Port); |
There was a problem hiding this comment.
- Handle the case of SOCKS proxies
- Are https and http proxies both considered to be ProxyType.HTTP or?
- Handle unsupported proxy types
There was a problem hiding this comment.
Handled the Socks proxies.
According to this, there is no value for https in the Java proxy type, which SlCore uses.
For unsupported proxy types: returning HTTP seemed the most appropriate, although I added a log for this case.
… proxy is configured and pass it to SlCore.
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
georgii-borovinskikh-sonarsource
approved these changes
Dec 17, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1694