SLVS-1690 Analyze CFamily header files as such to avoid FPs #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
michael-jabbour-sonarsource
changed the title
michael-jabbour-sonarsource
changed the title
michael-jabbour-sonarsource
force-pushed
the
mj/SLVS-1690_header_analysis
branch
19 times, most recently
from
6c0c88c to
eaf7185
Compare
michael-jabbour-sonarsource
force-pushed
the
mj/SLVS-1690_header_analysis
branch
2 times, most recently
from
646847c to
ec44167
Compare
michael-jabbour-sonarsource
requested a review
from mostafa-mohammed-sonarsource
mostafa-mohammed-sonarsource
approved these changes
Dec 16, 2024
georgii-borovinskikh-sonarsource
force-pushed
the
gb/vcx-env-vars
branch
from
131288c to
fd4fdc9
Compare
Base automatically changed from
gb/vcx-env-vars
to
feature/cfamily-migration
December 16, 2024 13:40
Temporarily use unreleased version to test changes SonarSource/sonar-cpp@e1e7a02
michael-jabbour-sonarsource
force-pushed
the
mj/SLVS-1690_header_analysis
branch
from
9f637f6 to
90d910f
Compare
This reverts commit 90d910f.
|
michael-jabbour-sonarsource
merged commit 82bdaab
into
feature/cfamily-migration
3 checks passed
georgii-borovinskikh-sonarsource
pushed a commit
that referenced
this pull request
Dec 24, 2024
[SLVS-1690](https://sonarsource.atlassian.net/browse/SLVS-1690) This is done by including a special environment variable in the compilation database entry generated for header files. This environment variable is recognized starting with CFamily analyzer v6.62 (CPP-5898). Additionally, the PR adds some verbose logs to describe which env variables were overwritten/added (similar to what we used to have [here](https://github.com/SonarSource/sonarlint-visualstudio/blob/6498da7a3788467884af7446966029aaab5625ce/src/CFamily/Subprocess/ProcessRunner.cs#L172-L1930)). [SLVS-1690]: https://sonarsource.atlassian.net/browse/SLVS-1690?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
georgii-borovinskikh-sonarsource
pushed a commit
that referenced
this pull request
Dec 24, 2024
[SLVS-1690](https://sonarsource.atlassian.net/browse/SLVS-1690) This is done by including a special environment variable in the compilation database entry generated for header files. This environment variable is recognized starting with CFamily analyzer v6.62 (CPP-5898). Additionally, the PR adds some verbose logs to describe which env variables were overwritten/added (similar to what we used to have [here](https://github.com/SonarSource/sonarlint-visualstudio/blob/6498da7a3788467884af7446966029aaab5625ce/src/CFamily/Subprocess/ProcessRunner.cs#L172-L1930)). [SLVS-1690]: https://sonarsource.atlassian.net/browse/SLVS-1690?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1690
This is done by including a special environment variable in the compilation database entry generated for header files. This environment variable is recognized starting with CFamily analyzer v6.62 (CPP-5898).
Additionally, the PR adds some verbose logs to describe which env variables were overwritten/added (similar to what we used to have here).