-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLVS-1392 Delete related bindings on deleting connection #5894
Merged
gabriela-trutan-sonarsource
merged 8 commits into
feature/unbind
from
gt/delete-connection
Dec 16, 2024
Merged
SLVS-1392 Delete related bindings on deleting connection #5894
gabriela-trutan-sonarsource
merged 8 commits into
feature/unbind
from
gt/delete-connection
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…rkaround until unbinding is implemented
…lint-visualstudio into gt/delete-connection
…ding folder is being deleted, so there is no need to do it again when the ServerIssuesChanged event is raised
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
December 13, 2024 12:46
gabriela-trutan-sonarsource
changed the title
SLVS-1392 Delete connected bindings on deleting connection
SLVS-1392 Delete related bindings on deleting connection
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall
src/Roslyn.Suppressions/Roslyn.Suppressions/InProcess/RoslynSettingsFileSynchronizer.cs
Outdated
Show resolved
Hide resolved
georgii-borovinskikh-sonarsource
approved these changes
Dec 16, 2024
…when binding folder is being deleted, so there is no need to do it again when the ServerIssuesChanged event is raised" This reverts commit 470f959.
Quality Gate passedIssues Measures |
gabriela-trutan-sonarsource
added a commit
that referenced
this pull request
Dec 17, 2024
gabriela-trutan-sonarsource
added a commit
that referenced
this pull request
Dec 18, 2024
vnaskos-sonar
pushed a commit
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1392