SLVS-1693 Fix: issues set to empty after hotspots event #5886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgii-borovinskikh-sonarsource
requested a review
from gabriela-trutan-sonarsource
georgii-borovinskikh-sonarsource
marked this pull request as ready for review
gabriela-trutan-sonarsource
approved these changes
Dec 13, 2024
| @@ -49,3 +44,15 @@ void ScheduleAnalysis(string filePath, | |||
| /// </summary> | |||
| void CancelForFile(string filePath); | |||
| } | |||
|
|
|||
| public interface IFindingsPublisher | |||
There was a problem hiding this comment.
Please move this interface into its own class.
| return analysisIssueVisualizations; | ||
| } | ||
|
|
||
| private bool ValidatePath(string path) |
There was a problem hiding this comment.
Please rename the method to something more speaking: for now, it is unexpected that the ValidatePath returns true in the case that it fails. Possible name: IsPathInvalid
Another approach would be to inverse the returns: in the fail case, it should return false.
| @@ -46,20 +39,18 @@ public void HandleNewIssues_UpdatedSnapshotAndHotspotStoreHaveExpectedValues() | |||
| { | |||
| var hotspotStoreMock = new Mock<ILocalHotspotsStoreUpdater>(); | |||
|
|
|||
| var hotspot = CreateIssue("S112", startLine: 1, endLine: 1, isHotspot: true); | |||
There was a problem hiding this comment.
Please rename the test as well: HandleNewIssues_UpdatedSnapshotHasExpectedValues
| @@ -87,6 +77,33 @@ public void HandleNewIssues_UpdatedSnapshotAndHotspotStoreHaveExpectedValues() | |||
| notificationHandler.UpdatedSnapshot.AnalyzedFilePath.Should().Be(expectedFilePath); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void HandleNewHotspots_UpdatedSnapshotAndHotspotStoreHaveExpectedValues() | |||
There was a problem hiding this comment.
Rename to
Suggested change
| public void HandleNewHotspots_UpdatedSnapshotAndHotspotStoreHaveExpectedValues() | |
| public void HandleNewHotspots_HotspotStoreHasExpectedValues() |
|
georgii-borovinskikh-sonarsource
merged commit 1d8a731
into
feature/cfamily-migration
3 checks passed
georgii-borovinskikh-sonarsource
added a commit
that referenced
this pull request
Dec 24, 2024
georgii-borovinskikh-sonarsource
added a commit
that referenced
this pull request
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1693