SLVS-1668 Include header file language in the VCX command #5861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
michael-jabbour-sonarsource
changed the title
michael-jabbour-sonarsource
changed the title
michael-jabbour-sonarsource
force-pushed
the
mj/workaround_for_cfamily_headers
branch
5 times, most recently
from
3a5f1f7 to
0594303
Compare
georgii-borovinskikh-sonarsource
force-pushed
the
gb/vcx-migration
branch
from
715e7da to
7acbb94
Compare
michael-jabbour-sonarsource
force-pushed
the
mj/workaround_for_cfamily_headers
branch
4 times, most recently
from
02beb4c to
8995923
Compare
michael-jabbour-sonarsource
changed the title
michael-jabbour-sonarsource
changed the title
michael-jabbour-sonarsource
changed the title
michael-jabbour-sonarsource
changed the title
michael-jabbour-sonarsource
changed the title
michael-jabbour-sonarsource
changed the title
michael-jabbour-sonarsource
changed the title
michael-jabbour-sonarsource
changed the title
michael-jabbour-sonarsource
requested a review
from mostafa-mohammed-sonarsource
Base automatically changed from
gb/vcx-migration
to
feature/cfamily-migration
December 4, 2024 13:44
michael-jabbour-sonarsource
force-pushed
the
mj/workaround_for_cfamily_headers
branch
from
aec5103 to
d58d1bc
Compare
georgii-borovinskikh-sonarsource
deleted the branch
feature/cfamily-migration
This helps analyze headers in C projects as C code. This is needed now that we no longer pass HeaderFileLanguage separately to the analyzer.
Normally, the CFamily analyzer deduces that the file being analyzed is a header when there is no exact match for the file name in the given compilation database. This is a temporary workaround to communicate with the analyzer that the current file is a header file. This helps the analyzer avoid reporting some FPs. See https://sonarsource.atlassian.net/browse/CPP-2743
michael-jabbour-sonarsource
force-pushed
the
mj/workaround_for_cfamily_headers
branch
from
d58d1bc to
471a48f
Compare
|
georgii-borovinskikh-sonarsource
approved these changes
Dec 10, 2024
georgii-borovinskikh-sonarsource
merged commit 37eb38b
into
feature/cfamily-migration
4 checks passed
georgii-borovinskikh-sonarsource
deleted the
mj/workaround_for_cfamily_headers
branch
georgii-borovinskikh-sonarsource
pushed a commit
that referenced
this pull request
Dec 24, 2024
[SLVS-1668](https://sonarsource.atlassian.net/browse/SLVS-1668) Part of SLVS-1637 See the linked ticket for details about the problems we identified. This PR introduces the following changes: - To communicate the header file language, I am adding the relevant switches to the generated command in the header case as well. This helps analyze C headers as such when they are located inside C VCX projects. - Since `HeaderFileLanguage` is no longer needed, I am removing it from `FileConfig`. [SLVS-1668]: https://sonarsource.atlassian.net/browse/SLVS-1668?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
georgii-borovinskikh-sonarsource
pushed a commit
that referenced
this pull request
Dec 24, 2024
[SLVS-1668](https://sonarsource.atlassian.net/browse/SLVS-1668) Part of SLVS-1637 See the linked ticket for details about the problems we identified. This PR introduces the following changes: - To communicate the header file language, I am adding the relevant switches to the generated command in the header case as well. This helps analyze C headers as such when they are located inside C VCX projects. - Since `HeaderFileLanguage` is no longer needed, I am removing it from `FileConfig`. [SLVS-1668]: https://sonarsource.atlassian.net/browse/SLVS-1668?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1668
Part of SLVS-1637
See the linked ticket for details about the problems we identified. This PR introduces the following changes:
HeaderFileLanguageis no longer needed, I am removing it fromFileConfig.