Change ProjectRootCalculator to use IActiveSolutionBoundTracker #5071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgii-borovinskikh-sonarsource
requested a review
from ugras-ergun-sonarsource
georgii-borovinskikh-sonarsource
linked an issue
ugras-ergun-sonarsource
approved these changes
Dec 1, 2023
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -49,7 +49,7 @@ public void MefCtor_CheckIsSingleton() | |||
| public async Task CalculateBasedOnLocalPathAsync_StandaloneMode_ReturnsNull() | |||
| { | |||
| var testSubject = CreateTestSubject(out _, out var configurationProviderMock, out _); | |||
There was a problem hiding this comment.
Change the variable name maybe
There was a problem hiding this comment.
Well, since this is pretty much is used like a configuration provider, I think it's not too confusing, and I'd rather just leave it like this and be done with the pr
georgii-borovinskikh-sonarsource
merged commit 7870ad7
into
feature/mute-server-issues
12 checks passed
georgii-borovinskikh-sonarsource
deleted the
gb/root-calculator-performance
branch
ugras-ergun-sonarsource
pushed a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5070